Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust default/generic config for printrboards #6755

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CharlesScoville
Copy link

@CharlesScoville CharlesScoville commented Dec 1, 2024

Most Printrbot 3D printers that shipped with the printrboard (Printrbot simple, Simple Metal 1403, Simple Metal 2016 V2, Play, etc.) had the Y endstop on Y max, and the Y stepper direction reversed. Furthermore, the build volumes were more commonly 150mm.

I have edited the relevant config file to reflect this. I have also tested the changes on a Printrbot Simple Metal 1403, and it works as expected.

Edit:
Signed-off-by: Charles Lee Scoville

…ot simple, Simple Metal 1403, Simple Metal 2016 V2, Play, etc.) had the Y endstop on Y max, and the Y stepper direction reversed. Furthermore, the build volums were more commonly 150mm.
@JamesH1978
Copy link
Collaborator

Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks
James

… simple, Simple Metal 1403, Simple Metal 2016 V2, Play, etc.) had the Y endstop on Y max, and the Y stepper direction reversed. Furthermore, the build volums were more commonly 150mm.

Signed-off-by: Charles Lee Scoville.
@CharlesScoville
Copy link
Author

Sorry for the delay, have a lot going on. I have tried to do as you asked, but github fights me. Hopefully I have correct now? If nothing else, I can sign off in the comments here.

@JamesH1978
Copy link
Collaborator

Thank you for the update, but as the docs state we need a name and an email address to fully sign off. Apart from that I cant see an issue, as the change reflects the most common use of these boards.

Thanks
James

Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants